change to not use NetworkConfig in hash calculation if it has default value #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
|
Did you test that this actually addresses the issue? |
|
Yes. Tested upgrading from 0.2.0 to 0.4.1, no rolling update. Afterward I made a change that doesn't trigger rolling update, NetworkConfig did get defaulted, but it doesn't trigger rolling update either. |
|
/lgtm Thanks, can you please submit a patch? |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, Edwinhr716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 7, 2024
…-upstream-release-0.4.0 Automated cherry pick of #250: change to not use NetworkConfig in hash calculation if it has default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it
When calculating the template hash, if the NetworkConfig has the defaulted value, it will not be used. This is to prevent a rolling update to be triggered when upgrading from a previous version.
Which issue(s) this PR fixes
Fixes #240
Special notes for your reviewer
Does this PR introduce a user-facing change?