Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis ClusterOutput API docs should include the units #108

Open
catherineluse opened this issue Nov 22, 2022 · 1 comment
Open

Redis ClusterOutput API docs should include the units #108

catherineluse opened this issue Nov 22, 2022 · 1 comment

Comments

@catherineluse
Copy link
Contributor

The documentation for Redis ClusterOutputs specifies TTL for keys: https://banzaicloud.com/docs/one-eye/logging-operator/configuration/plugins/outputs/redis/#ttl-int-optional-output-config-ttl

What unit is that in? Seconds?

@fekete-robert
Copy link
Collaborator

Great question, it seems that the unit isn't mentioned in the docs of the fluent plugin either (logging operator just passes the value to the plugin), but based on the example in the plugin readme (https://github.com/fluent-plugins-nursery/fluent-plugin-redis) I'd guess it's in seconds.

@bshifter do you know what's the unit of the TTL parameter in https://github.com/banzaicloud/logging-operator/blob/master/pkg/sdk/logging/model/output/redis.go ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants