From 59699fa427e31ab779cd447c16e3cd35cc459235 Mon Sep 17 00:00:00 2001 From: Kylie Smith Date: Mon, 9 Oct 2023 16:53:07 +1000 Subject: [PATCH] Start of DB metrics --- src/database/database_server.cpp | 60 ++++++++++++++++++++++++++++++++ src/database/database_server.h | 17 +++++++++ 2 files changed, 77 insertions(+) diff --git a/src/database/database_server.cpp b/src/database/database_server.cpp index 6a12df4..20e095b 100644 --- a/src/database/database_server.cpp +++ b/src/database/database_server.cpp @@ -112,9 +112,11 @@ void DatabaseServer::HandleDatagram(const std::shared_ptr &dg) { break; case DBSERVER_OBJECT_DELETE_FIELD: case DBSERVER_OBJECT_DELETE_FIELDS: + // TODO: Implement this. Logger::Error("[DB] OBJECT_DELETE_FIELD(S) NOT YET IMPLEMENTED!"); break; case DBSERVER_OBJECT_SET_FIELD_IF_EMPTY: + // TODO: Implement this. Logger::Error("[DB] OBJECT_SET_FIELD_IF_EMPTY NOT YET IMPLEMENTED!"); break; case DBSERVER_OBJECT_SET_FIELD_IF_EQUALS: @@ -149,6 +151,10 @@ uint32_t DatabaseServer::AllocateDoId() { // We've been allocated a DoId! if (doIdObj) { + if (_freeChannelsGauge) { + _freeChannelsGauge->Decrement(); + } + return DatabaseUtils::BsonToNumber( doIdObj->view()["doId"]["next"].get_value()); } @@ -164,6 +170,10 @@ uint32_t DatabaseServer::AllocateDoId() { << close_document << finalize); if (freeObj) { + if (_freeChannelsGauge) { + _freeChannelsGauge->Decrement(); + } + return DatabaseUtils::BsonToNumber( freeObj->view()["doId"]["free"].get_array().value[0].get_value()); } @@ -190,6 +200,10 @@ void DatabaseServer::FreeDoId(const uint32_t &doId) { << "GLOBALS" << finalize, document{} << "$push" << open_document << "doId.free" << static_cast(doId) << close_document << finalize); + + if (_freeChannelsGauge) { + _freeChannelsGauge->Increment(); + } } catch (const mongocxx::operation_exception &e) { Logger::Error( std::format("[DB] Failed to free DoId: {}: {}", doId, e.what())); @@ -783,6 +797,52 @@ void DatabaseServer::InitMetrics() { } auto registry = Metrics::Instance()->GetRegistry(); + + auto &freeChannelsBuilder = prometheus::BuildGauge() + .Name("db_free_channels_size") + .Help("Number of free channels") + .Register(*registry); + + auto &opsCompletedBuilder = + prometheus::BuildCounter() + .Name("db_ops_completed") + .Help("Number of successful database operations") + .Register(*registry); + + auto &opsFailedBuilder = prometheus::BuildCounter() + .Name("db_ops_failed") + .Help("Number of failed database operations") + .Register(*registry); + + auto &opsTimeBuilder = + prometheus::BuildHistogram() + .Name("db_ops_time") + .Help("Time taken for a successful database operation to complete") + .Register(*registry); + + _freeChannelsGauge = &freeChannelsBuilder.Add({}); + + // Map operation types to a human-readable string. + // These will be displayed in Prometheus/Grafana. + const std::vector> OPERATIONS = { + {OperationType::CREATE_OBJECT, "create_object"}, + {OperationType::DELETE_OBJECT, "delete_object"}, + {OperationType::GET_OBJECT, "get_object"}, + {OperationType::GET_OBJECT_FIELDS, "get_fields"}, + {OperationType::SET_OBJECT_FIELDS, "set_fields"}, + {OperationType::UPDATE_OBJECT_FIELDS, "update_fields"}}; + + // Populate operation maps. + for (const auto &opType : OPERATIONS) { + _opsCompleted[opType.first] = + &opsCompletedBuilder.Add({{"op_type", opType.second}}); + _opsFailed[opType.first] = + &opsFailedBuilder.Add({{"op_type", opType.second}}); + _opsCompletionTime[opType.first] = &opsTimeBuilder.Add( + {{"op_type", opType.second}}, + prometheus::Histogram::BucketBoundaries{0, 500, 1000, 1500, 2000, 2500, + 3000, 3500, 4000, 4500, 5000}); + } } } // namespace Ardos diff --git a/src/database/database_server.h b/src/database/database_server.h index f749352..9772719 100644 --- a/src/database/database_server.h +++ b/src/database/database_server.h @@ -3,6 +3,8 @@ #include #include +#include +#include #include "../messagedirector/channel_subscriber.h" #include "../net/datagram_iterator.h" @@ -49,6 +51,21 @@ class DatabaseServer : public ChannelSubscriber { mongocxx::uri _uri; mongocxx::client _conn; mongocxx::database _db; + + prometheus::Gauge *_freeChannelsGauge = nullptr; + + enum OperationType { + CREATE_OBJECT, + DELETE_OBJECT, + GET_OBJECT, + GET_OBJECT_FIELDS, + SET_OBJECT_FIELDS, + UPDATE_OBJECT_FIELDS, + }; + + std::unordered_map _opsCompleted; + std::unordered_map _opsFailed; + std::unordered_map _opsCompletionTime; }; } // namespace Ardos