Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use generic Set instead of deprecated sets.String #422

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Aug 30, 2023

Motivation

To address deprecation warnings which appeared after updating to Go 1.19 in #379

Modifications

Updated deprecated code following sets package doc, e.g.:

use generic Set instead. new ways: s1 := Set[string]{} s2 := New[string] ()

Result

Resolves #386

@rafvasq rafvasq requested review from ckadner and removed request for joerunde August 30, 2023 19:26
@rafvasq rafvasq marked this pull request as ready for review September 5, 2023 21:54
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ckadner, rafvasq
To complete the pull request process, please assign tjohnson31415 after the PR has been reviewed.
You can assign the PR to them by writing /assign @tjohnson31415 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@ckadner ckadner added the lgtm label Sep 13, 2023
@ckadner ckadner merged commit 0b39182 into kserve:main Sep 13, 2023
5 checks passed
@ckadner
Copy link
Member

ckadner commented Sep 13, 2023

Thanks @rafvasq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated code after moving to Go 1.19
3 participants