Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not dependencies be relaxed or updated? #2

Open
madjestic opened this issue May 23, 2020 · 8 comments
Open

Should not dependencies be relaxed or updated? #2

madjestic opened this issue May 23, 2020 · 8 comments

Comments

@madjestic
Copy link
Collaborator

Hey guys,

I've edited the .cabal like this:
https://github.com/madjestic/iexcloud/blob/iexcloud/iexcloud.cabal
And it built ok.

Should not the dependencies be more relaxed to be more future ompatible? Or, perhapse, there needs to be a new release?

Cheers.
Vlad

@ksallberg
Copy link
Owner

Hello,

I think that you are probably right. I have not used this lib since IEX started charging for basic features - I cannot even run the tests anymore. I don't know how to get around that.

@ksallberg
Copy link
Owner

I contacted IEX support to ask if they can provide this project with some sort of API key we can use for testing and development. @madjestic would you like to create a PR?

@madjestic
Copy link
Collaborator Author

I think they still have a free version "Test your ideas with 50,000 core messages/mo on a limited platform for free." Do you know of a better alternative though?

I'll create a PR.

Cheers,
Vlad

@madjestic
Copy link
Collaborator Author

madjestic commented May 26, 2020

Dang, I think I screwed up the PR. I've changed a few more files which I'd rather not share and I don't know an easy way to just PR the cabal... Maybe I need to finish the clean up at least.

@madjestic
Copy link
Collaborator Author

madjestic commented May 26, 2020

I contacted IEX support to ask if they can provide this project with some sort of API key we can use for testing and development.

https://intercom.help/iexcloud/en/articles/2915433-testing-with-the-iex-cloud-sandbox
Is that not what you are looking for?

@ksallberg
Copy link
Owner

ksallberg commented May 27, 2020

@madjestic no worries. yes right, we already have some functions that use the sandbox API - I had just forgotten. issue #1 is about that

@madjestic
Copy link
Collaborator Author

madjestic commented May 30, 2020

I noticed that every *.hs file seems to have import Data.Maybe, even if it's redundant. Is that intentional?

For now I commented out everything that I get a warning from ghc.

@ksallberg
Copy link
Owner

No it is not intential, it is probably a copy paste error. From the beginning we had just one .hs file with all functions in, but then I separated into several files because otherwise the record fields would conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants