Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Bad property values should generate warning rather than failing to parse #26

Open
GoogleCodeExporter opened this issue Jun 11, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

If there is some attributes not supported, the SVG can't be shown.
Such as:  stroke-linecap="null" stroke-linejoin="null" 

If it possible for just ignore these attributes in text element?

Original issue reported on code.google.com by [email protected] on 6 Jan 2014 at 7:15

@GoogleCodeExporter
Copy link
Author

Where did that file come from?  Was it generated from an editor or another 
program?  Or was it a file you made yourself?  If it was from some external 
program, please let me know what it is. Thanks.

When I started writing the library, I made the decision to throw exceptions and 
fail the parse when I encountered errors such as this.  This was because I 
figured nearly everyone would be using the library with static valid files.  
I've since decided that this was a wrong decision and already had it on my 
to-do list to change this behaviour.

Bug accepted

Thanks for using AndroidSVG.

Original comment by [email protected] on 6 Jan 2014 at 7:53

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Updated summary text.

Original comment by [email protected] on 6 Jan 2014 at 7:55

  • Changed title: Request: Bad property values should generate warning rather than failing to parse

@GoogleCodeExporter
Copy link
Author

This SVG is created with a svg web editor - svg-edit:
<svg width="640" height="480" xmlns="http://www.w3.org/2000/svg">
 <!-- Created with SVG-edit - http://svg-edit.googlecode.com/ -->
 <g>
  <title>Layer 1</title>
  <path d="m131,96c0,1 0,3 0,4c0,2 0.68925,3.08025 0,6c-0.51375,2.17625 -0.51945,4.03873 -1,7c-0.50655,3.12144 -1,6 -1,9c0,2 0,4 0,7c0,3 0,6 0,8c0,3 0,6 0,10c0,3 -0.22975,4.02675 0,5c0.51375,2.17625 0.82375,3.48625 3,4c2.91975,0.68925 6,0 10,0c4,0 8,0 12,0c7,0 14,0 21,0c8,0 14,0 21,0c3,0 5,0 7,0c1,0 1,2 1,3c0,1 0.38269,2.07613 0,3c-0.5412,1.30656 -1,2 -2,4c-1,2 -1.29289,3.29289 -2,4c-1.41422,1.41422 -0.34619,2.70546 -2,5c-1.30745,1.814 -0.61731,3.07613 -1,4c-0.5412,1.30656 -1.14935,2.47427 -2,3c-1.90211,1.17557 -2,2 -2,3c0,1 -0.61731,2.07613 -1,3c-0.5412,1.30656 -1,2 -1,3c0,1 -0.4595,2.0535 0,4c0.51375,2.17625 1.1731,2.85274 2,4c1.30745,1.814 1.1731,2.85274 2,4c1.30745,1.814 3,2 4,2c1,0 2,0 3,0c1,0 2.07613,-0.38269 3,0c1.30656,0.5412 1.77025,2.02675 2,3c0.51375,2.17625 2,3 2,4c0,2 0,4 0,5c0,1 0,2 0,3c0,1 0.22975,3.02675 0,4c-0.51375,2.17625 -2.69255,3.186 -4,5c-0.8269,1.14726 -1.82375,2.48625 -4,3c-0.97325,0.22975 -1.69344,1.4588 -3,2c-0.92387,0.38269 -3,2 -4,2c-2,0 -2,1 -2,2c0,2 -1.41422,3.58578 0,5c0.70711,0.70711 0.77025,2.02675 1,3c0.51375,2.17625 1,4 1,6c0,2 2,5 2,6c0,2 1,4 1,5c0,1 0,3 0,4l1,2l0,1" id="svg_1" stroke-width="5" stroke="#000000" fill="none"/>
  <line id="svg_2" y2="297" x2="360" y1="107" x1="379" stroke-width="5" stroke="#000000" fill="none"/>
  <path id="svg_3" d="m82,186c0,0 -40,92 -40,93c0,1 108,27 109,27c1,0 -7,-92 -7,-92c0,0 -62,-28 -62,-28z" stroke-width="5" stroke="#000000" fill="#ff0000"/>
  <text xml:space="preserve" text-anchor="middle" font-family="serif" font-size="24" id="svg_4" y="237" x="265" stroke-linecap="null" stroke-linejoin="null" stroke-dasharray="null" stroke-width="0" stroke="#000000" fill="#000000">ABCD</text>
 </g>
</svg>

Original comment by [email protected] on 6 Jan 2014 at 9:05

@GoogleCodeExporter
Copy link
Author

Ok. Thanks for that info.  svg-edit should not be generating invalid files like 
that.  I will also report that issue with them.


Original comment by [email protected] on 6 Jan 2014 at 11:26

@GoogleCodeExporter
Copy link
Author

I have filed a bug report with svg-edit for their half of the problem:

https://code.google.com/p/svg-edit/issues/detail?id=1170

Original comment by [email protected] on 6 Jan 2014 at 11:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant