Don't store null terminator in string buffer #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not accounting for the null terminator in the string allocation, meaning that every string copy overflowed its buffer by one byte. Usually the null terminator ended up getting overwritten by the first character of the next string copied into the buffer, but occasionally, due to concurrency, the null terminator from the first string could overwrite the first character of the second. Since the null terminator is not actually necessary, this commit removes it from the string buffer. Now the allocation size is correct.
mreishus
added a commit
to mreishus/tombs
that referenced
this pull request
May 7, 2024
From: krakjoe#17 --- We were not accounting for the null terminator in the string allocation, meaning that every string copy overflowed its buffer by one byte. Usually the null terminator ended up getting overwritten by the first character of the next string copied into the buffer, but occasionally, due to concurrency, the null terminator from the first string could overwrite the first character of the second. Since the null terminator is not actually necessary, this commit removes it from the string buffer. Now the allocation size is correct. Fixes #16 using the first solution suggested in that issue. Read that issue for further details. The alternative would be to increase each string allocation size by 1. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not accounting for the null terminator in the string allocation, meaning that every string copy overflowed its buffer by one byte.
Usually the null terminator ended up getting overwritten by the first character of the next string copied into the buffer, but occasionally, due to concurrency, the null terminator from the first string could overwrite the first character of the second.
Since the null terminator is not actually necessary, this commit removes it from the string buffer. Now the allocation size is correct.
Fixes #16 using the first solution suggested in that issue. Read that issue for further details. The alternative would be to increase each string allocation size by 1.