New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payload values should override builder provided payload props #71

Open

jamischarles opened this issue Mar 10, 2023 · 1 comment

Assignees

Labels

Contributor

jamischarles commented Mar 10, 2023

I would expect payload values passed in directly to logger methods to override builder provided props.

The opposite is true. I think we should consider swapping the order on these:
https://github.com/krakenjs/beaver-logger/blob/main/src/logger.js#L222-L229

Contributor

westeezy commented Mar 15, 2023

I agree with that. I'll add a ticket to investigate a bit to ensure we want to move forward and make the change in the next version. <3

westeezy self-assigned this

westeezy added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment