Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Upload: abortUpload() and scrubFilename() need to accept file in addition to filename #12

Open
basinilya opened this issue Jan 25, 2023 · 0 comments

Comments

@basinilya
Copy link

It should be possible to upload files having same name. For instance, you can search for a file in Windows Explorer and then drop the search results to a drop zone.

scrubFilename() is supposed to return unique S3 Key for such files, but it's currently impossible to handle duplicates in it because the file object is not passed to it.

abortUpload() also needs the file parameter so it can be passed to scrubFilename()

And it looks like uploadToS3() always creates a new instance of Evaporate and this makes usage of this.evaporate in abortUpload() unreliable. (unless Evaporate.create() returns a singleton. Does it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant