Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo web suppresses error output when JSON is too nested #215

Open
aidanhs opened this issue Sep 26, 2019 · 1 comment · May be fixed by #237
Open

Cargo web suppresses error output when JSON is too nested #215

aidanhs opened this issue Sep 26, 2019 · 1 comment · May be fixed by #237

Comments

@aidanhs
Copy link

aidanhs commented Sep 26, 2019 •
edited
Loading 

$ RUST_LOG=trace cargo web deploy --target wasm32-unknown-unknown --release
   Compiling XX-page v0.1.0 (/home/aidanhs/Desktop/per/XX/page)
warning: unused import: `TimeoutTask`
  --> src/lib.rs:16:46
   |
16 | use yew::services::timeout::{TimeoutService, TimeoutTask};
   |                                              ^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

thread 'main' panicked at 'failed to parse cargo output: Error("recursion limit exceeded", line: 1, column: 122250)', src/libcore/result.rs:1165:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

cargo-web/src/cargo_shim/mod.rs

Line 823 in 4dce450

let json: serde_json::Value = serde_json::from_str( &line ).expect( "failed to parse cargo output" );

I've recently upgraded yew and have presumably got something wrong, but there seems to be no way to get the actual output if the parse fails.
@aidanhs aidanhs changed the title Cargo web suppresses erroring output when JSON is too deep Cargo web suppresses erroring output when JSON is too nested Sep 26, 2019
@aidanhs aidanhs changed the title Cargo web suppresses erroring output when JSON is too nested Cargo web suppresses error output when JSON is too nested Sep 26, 2019
@aidanhs
Copy link
Author

aidanhs commented Sep 26, 2019

(had to clone and build cargo web with an inserted println to figure it out, turned out to be a simple incorrect type deep in the yew html! macro)

aidanhs added a commit to aidanhs/cargo-web that referenced this issue Jan 22, 2020
@aidanhs
Allow unbounded recursion and remove double parsing json
c84cb38 
Reasoning: we trust Cargo output and fixes koute#215
@aidanhs aidanhs linked a pull request Jan 22, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow unbounded recursion and remove double parsing json aidanhs/cargo-web
1 participant
@aidanhs