Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support copying private links instead of public links #43

Closed
wants to merge 1 commit into from

Conversation

EricKotato
Copy link
Member

This PR tracks progress for option to copy private link instead of public one.

Why bother?

  1. These links won't generate any previews (even if channel/supergroup has a public username).
  2. These links will work even if channel/group username will be changed, since IDs are static.

Current state

  • Support to copy private links
  • Way to activate it

About how to activate it

For me, I think that best option here is to Shift/Ctrl+click on "Copy post link" option. But since I'm not seeing a way to make it with Ui::PopupMenu, here is some alternatives:

  • Adding a separate "Copy private link" option. It's visible, but menu will grow.
  • Kotatogram Settings option. Yes, settings menu will also grow, but that's inevitable. Much bigger problem here is that if you want to copy other link, you need to open settings menu.

So, most favorable option is Shift/Ctrl+click. Hope I don't need to hack Ui::PopupMenu for this.

@KlausEverWalkingDev
Copy link

That's certainly would be a nice feature to be added 🤩

@EricKotato EricKotato mentioned this pull request Jan 18, 2021
@dotvhs
Copy link

dotvhs commented Feb 25, 2022

So I've been thinking a bit to other approaches for activation of this feature and I do like this shift/ctrl+click approach, but I figured i would explore some more ideas:
Artboard
Two actions on single button
Clicking the main, large area would copy public link, clicking icon on the side would copy the private link.

Artboard
A submenu as a button
"Copy Message Link" could serve both as hover for submenu but also as button, so technically we wouldn't have to go into submenu to copy the link, just hit "Copy Message Link" (which would do the same as Copy public link button in this example). Unfortunately this solution also means that people would have to figure it out by themselves by trying to click it.

@KlausEverWalkingDev
Copy link

So I've been thinking a bit to other approaches for activation of this feature and I do like this shift/ctrl+click approach, but I figured i would explore some more ideas: Artboard Two actions on single button Clicking the main, large area would copy public link, clicking icon on the side would copy the private link.

Artboard A submenu as a button "Copy Message Link" could serve both as hover for submenu but also as button, so technically we wouldn't have to go into submenu to copy the link, just hit "Copy Message Link" (which would do the same as Copy public link button in this example). Unfortunately this solution also means that people would have to figure it out by themselves by trying to click it.

I could add that you could make a screen where those Telegram links' are pasted automatically. As Telegram doesn't have a "follow" feature, that screen would be a nice way to create a lists of all the chats you have known, even if you're not in there, maybe to be exported and/or to fill a list feature or something like that. Message links could be featured in a "Favorite Messages" (similar to what Graph Messenger does, but with only the links and not the whole forwarded message) screen and links with only the username or ID could be in a "Following" screen. Sorry if I didn't make my suggestion understandable. 😓

@EricKotato
Copy link
Member Author

Well, I guess TDesktop has it now since 5.7.2:
telegramdesktop/tdesktop@5295362

@EricKotato EricKotato closed this Nov 27, 2024
@EricKotato EricKotato deleted the copy-private-link branch November 28, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants