Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for manually cherry-picking are incorrect as they do not skip merge commits #395

Closed
jrhemstad opened this issue Nov 6, 2023 · 2 comments · Fixed by #397
Closed
Labels
bug Something isn't working prio: next Planning to work on this issue next

Comments

@jrhemstad
Copy link

Describe the bug

When the automatic backport fails due to conflicts in cherry-picking individual commits it will helpfully give instructions on how to manually do the cherry-pick:

git fetch origin branch/2.3.x
git worktree add -d .worktree/backport-574-to-branch/2.3.x origin/branch/2.3.x
cd .worktree/backport-574-to-branch/2.3.x
git checkout -b backport-574-to-branch/2.3.x
ancref=$(git merge-base 83b3365bbc12a9db248b67c22052413d41fae97e 9e9fb70b712a6799791997d3c70db6a28a71af72)
git cherry-pick -x $ancref..9e9fb70b712a6799791997d3c70db6a28a71af72

However, these instructions aren't correct if the PR contains merge commits as it omits the logic for filtering out merge commits.

To Reproduce
Steps to reproduce the behavior:

  1. Create and merge a pull request with merge commits that also will have merge conflicts on the target branch
  2. Trigger the backport workflow
  3. Backport fails and comments instructions on manual cherry-picking

Expected behavior
The instructions should include how to filter out merge commits.

Workflow run logs
https://github.com/NVIDIA/cccl/actions/runs/6750303904/job/18352417643

@korthout
Copy link
Owner

korthout commented Nov 7, 2023

That's definitely problematic and a big loss of QoL. I'll prioritize fixing this. Thanks for raising it @jrhemstad

@korthout korthout added the prio: next Planning to work on this issue next label Nov 7, 2023
@korthout
Copy link
Owner

korthout commented Nov 7, 2023

Fixed in v2.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio: next Planning to work on this issue next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants