-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project with pure kotlin and android modules #92
Comments
Could you provide a sample reproducer project? |
Yes, will try to provide one :) |
Created a sample project: https://github.com/JohannesPtaszyk/Pitest-Issue-92 Issue is that the Plugin tries to find "android" property for non-android modules.
|
Hey, just wanted to ask if the example is okay for you or if you need more info :) |
Sorry I missed the notification about the update. |
It's fine :) If you need any more information, let me know! |
This plugin supports only Android modules. |
That was the plan at the beginning, but Maybe @JohannesPtaszyk you could use the regular Pitest plugin for pure kotlin modules and this Android fork for the others? It's not perfect, but most likely even aggregation should work (as it uses upstream PIT mechanism under the hood)? Btw, I haven't tested it, but AFAIR the plugin doesn't refer to the root project anymore. |
I would highly suggest to support both types for the android one. Maybe it makes sense to list the differences between working with android vs plain java/kotlin modules? |
@JohannesPtaszyk Could you - just as a PoC - give the following configuration a try:
? |
Yeah will look into it on the weekend :) |
I updated the dependencies of my test project and added the plugins. However I still get an issue, where I don't know whats going on:
Commit on the test repo: |
What command did you call?
I don't have required Android stuff. Could you add simple CI build to that project? And remember to call Btw, add |
Called |
Seems to be working by adding targetClasses. |
@JohannesPtaszyk Have you checked the documentation and configured something like:
? You still didn't enable the CI build, so I can only guess...
Due to the aforementioned reasons, the original plugin for "pure Java apps" will not support also Android projects in the foreseeable future (unless there are some changes in Gradle itself). Maybe @koral-- will add "pure Java apps" support for his fork. |
Didn't have time to setup CI yet, will try to get to it soon. |
Got it working now, so seems to work with that approach, but I think it is far from a nice setup. |
Feel free to create a PR. |
Hello,
Am I missing something or does this fork not support mulit-module projects if there are plain java/kotlin modules?
The text was updated successfully, but these errors were encountered: