Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kor-button is not an accessible button #121

Open
motss opened this issue Aug 8, 2022 · 1 comment
Open

kor-button is not an accessible button #121

motss opened this issue Aug 8, 2022 · 1 comment

Comments

@motss
Copy link

motss commented Aug 8, 2022

Describe the bug
kor-button should be an accessible button just like how native button behaves in all platforms.

To Reproduce
Steps to reproduce the behavior:

  1. Render kor-button
  2. Inspect the elements
  3. kor-button is not rendered as an accessible button

Expected behavior
kor-button to be accessible or simply wrap slotted content with button with custom stylings

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS [e.g. iOS]: All OSes
  • Browser [e.g. chrome, safari]: All browsers
  • Version [e.g. 22]: v1.11.0
@Nrosa01
Copy link

Nrosa01 commented Dec 28, 2023

If you look at the code, kor button it's just a kor icon and a slot. It's not a real button, it doesn't trigger callbacks, I don't understand why they did this

  render() {
    return html`
      <slot name="icon">
        ${this.icon ? html` <kor-icon icon="${this.icon}"></kor-icon> ` : ''}
      </slot>
      <slot> ${this.label ? html` ${this.label} ` : ''}</slot>
    `;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants