Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing points in CI #45

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix missing points in CI #45

merged 2 commits into from
Feb 9, 2024

Conversation

pzehner
Copy link
Collaborator

@pzehner pzehner commented Feb 9, 2024 •
edited
Loading

As an addendum to #44, this PR finalizes two improvements on the CI:

  • Fix old names of images for cleanup; and
  • Allow to generate and cleanup base images manually (through GitHub).

@pzehner pzehner self-assigned this Feb 9, 2024
@pzehner pzehner marked this pull request as ready for review February 9, 2024 15:37
yasahi-hpc
yasahi-hpc approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
I will merge this.

By the way, do you have any idea to test the workflow of auto cleanup capability?

@yasahi-hpc yasahi-hpc merged commit 2dfd5c3 into main Feb 9, 2024
13 checks passed
@yasahi-hpc yasahi-hpc deleted the feature/fix-ci branch February 9, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc approved these changes

Assignees

@pzehner pzehner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzehner @yasahi-hpc