Licenses are missing copyright information

[arctic-alpaca]

Hi,

both the Apache 2 and the MIT license are missing the copyright information.
For the Apache 2 license, the copyright placeholder is not filled in: https://github.com/knurling-rs/defmt/blob/main/LICENSE-APACHE#L189
For the MIT license, the copyright part at the top (Copyright <YEAR> <COPYRIGHT HOLDER>, see here) is missing.

[jonathanpallant]

The copyright line in that part of the Apache-2.0 licence is a template and is not supposed to be modified in the licence file itself. If you changed it, then you have a) modified the licence, and b) are telling anyone who reads your modified copy of the licence that they must put your copyright in their files when they wish to release it under your modified Apache-2.0 licence.

The copyright line is missing in the MIT file and we should fix that. I note it is also missing from the copy at GitHub.com/rust-lang so maybe we copied their file.

[arctic-alpaca]

You are correct, the Apache-2.0 license file should not be modified, my bad. Without any form of copyright notice, I'm unsure how the copyright is assigned when using this project under the Apache-2.0 license.

The Rust repository has a COPYRIGHT file.

[Urhengulas]

We do have

defmt/LICENSE-MIT

Line 1 in f5315e0

Copyright (c) Ferrous Systems

is this not enough?

[jonathanpallant]

I added that five days ago :)

[Urhengulas]

Perfect