Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate to kube_codegen #641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: migrate to kube_codegen #641

wants to merge 1 commit into from

Conversation

inspirit941
Copy link

@inspirit941 inspirit941 commented Oct 30, 2024 •
edited
Loading

Changes

migrate from deprecated generate-group.sh to kube_codegen

/kind

Fixes #636

referenced from knative-extensions/eventing-github#550

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 30, 2024

@inspirit941: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

migrate from deprecated generate-group.sh to kube_codegen

/kind

Fixes #636

referenced by knative-extensions/eventing-github#550

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 30, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inspirit941
Once this PR has been reviewed and has the lgtm label, please assign cardil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 30, 2024

Welcome @inspirit941! It looks like this is your first PR to knative-extensions/sample-source 🎉

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 30, 2024

Hi @inspirit941. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil Awaiting requested review from cardil

@upodroid upodroid Awaiting requested review from upodroid

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Update Deprecated generate-groups.sh to kube_codegen.sh
1 participant
@inspirit941