-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escrow contract: tweak the event TransactionCreated #1389
Comments
@jaybuidl with _asset you mean the token? but since this is the general escrow, it will always be main currency of the chain you're in right, so not necessary? |
For the native currency, let have I want to avoid having a variable which looks the same as if it was uninitialized, such as address(0) or string(""), to make the value more explicit and intentional. Ofc in the case of a token, _asset is the token address. |
yeah makes sense but, wasn't the crypto swap going to be a different smart contract than this one? In my mind there was going to be 1 smart contract for General Escrow (with the only possibility of using native token) and a different smart contract for Crypto Swaps |
Yeah different contracts but same interface if possible |
Escrow.TransactionCreated event: add the parameters
asset
,_deadline
and_transactionUri
.For example
https://github.com/kleros/kleros-v2/blob/dev/contracts/src/arbitration/arbitrables/Escrow.sol#L90-L95
The text was updated successfully, but these errors were encountered: