forked from rubocop/rubocop-rails
-
Notifications
You must be signed in to change notification settings - Fork 0
/
date.rb
171 lines (136 loc) · 4.99 KB
/
date.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# This cop checks for the correct use of Date methods,
# such as Date.today, Date.current etc.
#
# Using `Date.today` is dangerous, because it doesn't know anything about
# Rails time zone. You must use `Time.zone.today` instead.
#
# The cop also reports warnings when you are using `to_time` method,
# because it doesn't know about Rails time zone either.
#
# Two styles are supported for this cop. When `EnforcedStyle` is 'strict'
# then the Date methods `today`, `current`, `yesterday`, and `tomorrow`
# are prohibited and the usage of both `to_time`
# and 'to_time_in_current_zone' are reported as warning.
#
# When `EnforcedStyle` is `flexible` then only `Date.today` is prohibited.
#
# And you can set a warning for `to_time` with `AllowToTime: false`.
# `AllowToTime` is `true` by default to prevent false positive on `DateTime` object.
#
# @example EnforcedStyle: strict
# # bad
# Date.current
# Date.yesterday
# Date.today
#
# # good
# Time.zone.today
# Time.zone.today - 1.day
#
# @example EnforcedStyle: flexible (default)
# # bad
# Date.today
#
# # good
# Time.zone.today
# Time.zone.today - 1.day
# Date.current
# Date.yesterday
# date.in_time_zone
#
# @example AllowToTime: true (default)
# # good
# date.to_time
#
# @example AllowToTime: false
# # bad
# date.to_time
class Date < Base
include ConfigurableEnforcedStyle
MSG = 'Do not use `Date.%<method_called>s` without zone. Use ' \
'`Time.zone.%<day>s` instead.'
MSG_SEND = 'Do not use `%<method>s` on Date objects, because they ' \
'know nothing about the time zone in use.'
RESTRICT_ON_SEND = %i[to_time to_time_in_current_zone].freeze
BAD_DAYS = %i[today current yesterday tomorrow].freeze
DEPRECATED_METHODS = [
{ deprecated: 'to_time_in_current_zone', relevant: 'in_time_zone' }
].freeze
DEPRECATED_MSG = '`%<deprecated>s` is deprecated. ' \
'Use `%<relevant>s` instead.'
def on_const(node)
mod, klass = *node.children
# we should only check core Date class (`Date` or `::Date`)
return unless (mod.nil? || mod.cbase_type?) && method_send?(node)
check_date_node(node.parent) if klass == :Date
end
def on_send(node)
return unless node.receiver && bad_methods.include?(node.method_name)
return if allow_to_time? && node.method?(:to_time)
return if safe_chain?(node) || safe_to_time?(node)
check_deprecated_methods(node)
add_offense(node.loc.selector, message: format(MSG_SEND, method: node.method_name))
end
alias on_csend on_send
private
def check_deprecated_methods(node)
DEPRECATED_METHODS.each do |method|
next unless node.method?(method[:deprecated].to_sym)
message = format(DEPRECATED_MSG, deprecated: method[:deprecated], relevant: method[:relevant])
add_offense(node.loc.selector, message: message)
end
end
def check_date_node(node)
chain = extract_method_chain(node)
return if (chain & bad_days).empty?
method_name = (chain & bad_days).join('.')
day = method_name
day = 'today' if method_name == 'current'
message = format(MSG, method_called: method_name, day: day)
add_offense(node.loc.selector, message: message)
end
def extract_method_chain(node)
[node, *node.each_ancestor(:send)].map(&:method_name)
end
# checks that parent node of send_type
# and receiver is the given node
def method_send?(node)
return false unless node.parent&.send_type?
node.parent.receiver == node
end
def safe_chain?(node)
chain = extract_method_chain(node)
(chain & bad_methods).empty? || !(chain & good_methods).empty?
end
def safe_to_time?(node)
return unless node.method?(:to_time)
if node.receiver.str_type?
zone_regexp = /([+-][\d:]+|\dZ)\z/
node.receiver.str_content.match(zone_regexp)
else
node.arguments.one?
end
end
def allow_to_time?
cop_config.fetch('AllowToTime', true)
end
def good_days
style == :strict ? [] : %i[current yesterday tomorrow]
end
def bad_days
BAD_DAYS - good_days
end
def bad_methods
%i[to_time to_time_in_current_zone]
end
def good_methods
style == :strict ? [] : TimeZone::ACCEPTED_METHODS
end
end
end
end
end