Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: rm Arc around Arc<JsonRpcClient<HttpTransport>> #1500

Open
tcoratger opened this issue Oct 25, 2024 · 2 comments
Open

dev: rm Arc around Arc<JsonRpcClient<HttpTransport>> #1500

tcoratger opened this issue Oct 25, 2024 · 2 comments
Assignees
@Gerson2102
Labels
blocked Blocked right now for external reasons enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project.

Comments

@tcoratger
Copy link
Collaborator

tcoratger commented Oct 25, 2024 •
edited
Loading

Describe the enhancement request

At the moment, we have a lots of Arc around JsonRpcClient<HttpTransport> like here:

kakarot-rpc/src/test_utils/katana/mod.rs

Line 89 in 443e148

pub eoa: KakarotEOA<Arc<JsonRpcClient<HttpTransport>>>,

Thanks to xJonathanLEI/starknet-rs#666 and after the next release of starknet-rs we will be able to remove these Arc and just use a simple clone.
@tcoratger tcoratger added the enhancement Enhancement of the code, not introducing new features. label Oct 25, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Oct 25, 2024
@tcoratger tcoratger added good first issue Good first issue for people wanting to contribute to this project. blocked Blocked right now for external reasons labels Oct 25, 2024
@Gerson2102
Copy link
Contributor

Hey, I can do this. When is no longer blocked.

@tcoratger
Copy link
Collaborator Author

Sure @Gerson2102 assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gerson2102 Gerson2102

Labels
blocked Blocked right now for external reasons enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project.
Projects
No open projects
Kakarot on Starknet
Status: 🆕 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcoratger @Gerson2102