-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: add migration procedure for the MongoDB [2] #1293
Labels
enhancement
Enhancement of the code, not introducing new features.
Comments
greged93
added
the
enhancement
Enhancement of the code, not introducing new features.
label
Jul 15, 2024
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this issue
Aug 9, 2024
<!--- Please provide a general summary of your changes in the title above --> <!-- Give an estimate of the time you spent on this PR in terms of work days. Did you spend 0.5 days on this PR or rather 2 days? --> Time spent on this PR: ## Pull request type <!-- Please try to limit your pull request to one type, submit multiple pull requests if needed. --> Please check the type of change your PR introduces: - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? Do not assert the value is 0 at the end of load_bytecode leading to prover being able to Resolves kkrt-labs#1279, resolves kkrt-labs#1293 ## What is the new behavior? assert value is 0 at the end of load_bytecode <!-- Reviewable:start --> - - - This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1290) <!-- Reviewable:end --> --------- Co-authored-by: Clément Walter <[email protected]>
@anukkrit149 is this still needed? |
This issue needs scoping cc'ing @ClementWalter, as it has been mentioned now twice in Karnot weeklies, we need a MongoDB migration script that's ran every time we redeploy the mongoDB |
ClementWalter
changed the title
dev: add migration procedure for the MongoDB
dev: add migration procedure for the MongoDB [2]
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement request
Indexes have been added to the Mongo but we should have some migration procedure from Karnot in case we ever want to update these or change the Mongo models. This needs to be discussed with Karnot.
Tasks
The text was updated successfully, but these errors were encountered: