Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libjose instead of custom jwk implementation? #1

Open
jirutka opened this issue May 15, 2023 · 3 comments
Open

Use libjose instead of custom jwk implementation? #1

jirutka opened this issue May 15, 2023 · 3 comments
Labels
wontfix This will not be worked on

Comments

@jirutka
Copy link

jirutka commented May 15, 2023

jose is a C implementation of JWS and JWK (among others). It’s already packaged by major distros, as you can see on repology.

@jirutka jirutka changed the title Use libjose instead of custom jwk implementation Use libjose instead of custom jwk implementation? May 15, 2023
@kjdev
Copy link
Owner

kjdev commented May 15, 2023

I didn't use it because I couldn't find the function I wanted (get keys from JWK)

@kjdev kjdev added the wontfix This will not be worked on label May 21, 2023
@col-panic
Copy link

Maybe it would make sense to take this missing part (get keys from JWK) and contribute it to jose such that forces could be joined?

@col-panic
Copy link

Considering that this module is a security relevant element, especially as it enforces security requirements, it would be definitely good to re-use cryptographic implementations. Due to their (jose) focus on this topic they might also have additional tests running on the implementation.

Another topic is the upcoming https://en.wikipedia.org/wiki/Cyber_Resilience_Act - concerning this it would be great to have an SBOM to be capable of checking this. So consider you have your own implementation of the crypt algorithm a bug might not be identified, but if you depend on jose and they do regular reviews and this module has an SBOM such a bug could be tracked and remedied much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants