Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The module seems not effective at all #2

Open
DingLei14 opened this issue Oct 9, 2019 · 7 comments
Open

The module seems not effective at all #2

DingLei14 opened this issue Oct 9, 2019 · 7 comments

Comments

@DingLei14
Copy link

For my datasets the visualization of the residual part seems to be meaningless noises.

@kiyohiro8
Copy link
Owner

How did you find out that the GloRe unit seems ineffective?

@DingLei14
Copy link
Author

How did you find out that the GloRe unit seems ineffective?

I compared the ourput before & after using the module, and also visualized the residual part of the module (the 'y' part in 'x+y' in your code).
Actually, I found another implementation effective. I am not sure what's the difference between this implementation and yours though.

@kiyohiro8
Copy link
Owner

Thanks! I think some bugs are in my implementation. I will review and fix the code.

@gogowhy
Copy link

gogowhy commented Oct 21, 2019

could. you point out how to visualize the residual part?

@HauWong
Copy link

HauWong commented May 26, 2020

Thanks! I think some bugs are in my implementation. I will review and fix the code.

Hello, kiyohiro8. I wonder if you have managed this bug fix work? If yes, could you please commit it? Thanks very much.

@kiyohiro8
Copy link
Owner

I've been busy and haven't been able to get my hands on it, but I'll be making corrections within the next month. Please wait a little longer.

@NeverGiveU
Copy link

NeverGiveU commented Nov 3, 2021

Thanks! I think some bugs are in my implementation. I will review and fix the code.

Maybe it is because a line y = torch.transpose(y, 1, 2) is missed between #37 and #38 in layers/py ?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants