Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The release job is publishing the standalone APK in the GitHub release, which can not be uploaded to IzzyOnDroid due to a different package name. #4114

Open
MohitMaliFtechiz opened this issue Nov 28, 2024 · 3 comments · May be fixed by #4115
Open

The release job is publishing the standalone APK in the GitHub release, which can not be uploaded to IzzyOnDroid due to a different package name. #4114

MohitMaliFtechiz opened this issue Nov 28, 2024 · 3 comments · May be fixed by #4115
Assignees
@MohitMaliFtechiz
Labels
bug
Milestone
3.12.1

Comments

@MohitMaliFtechiz
Copy link
Collaborator

Describe the bug
We have just released version 3.12.0 of our application, and there is a standalone variant APK in GitHub release, which can not be uploaded on IzzyOnDroid since IzzyOnDroid uses the GitHub release to fetch the APK from our release and uploads it to their platform. See #4053 (comment)

Currently on IzzyOnDroid the application is published with the org.kiwix.kiwixmobile package name but our current standalone APK package name is org.kiwix.kiwixmobile.standalone which we have done to fix the #3933. Due to this issue, we have updated our release job to generate and upload the standalone APK to our website and the same APK we are uploading in the github release.

Expected behavior
We have to upload the application with the org.kiwix.kiwixmobile package name in the GitHub release so that IzzyOnDroid can easily update our application on their platform.
@MohitMaliFtechiz MohitMaliFtechiz self-assigned this Nov 28, 2024
@MohitMaliFtechiz MohitMaliFtechiz mentioned this issue Nov 28, 2024
Closed
@MohitMaliFtechiz MohitMaliFtechiz added this to the 3.12.1 milestone Nov 28, 2024
@MohitMaliFtechiz MohitMaliFtechiz linked a pull request Nov 28, 2024 that will close this issue
Open
@kelson42
Copy link
Collaborator

kelson42 commented Nov 28, 2024 •
edited
Loading

We are not going to change the appid. This change has been made to avoid confusions and we should stick to it.

@MohitMaliFtechiz
Copy link
Collaborator Author

We are just updating the release job to upload the application with the original package name. For the website and nightly APK, there are the same standalone APK will publish as published before.

@kelson42
Copy link
Collaborator

kelson42 commented Nov 28, 2024 •
edited
Loading

yes, the consequences will be that apk in github won't be the same as on download.kiwix.org and won't follow new approaches decided a few months ago in #3933. We don't need this kind of chaos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitMaliFtechiz MohitMaliFtechiz

Labels
bug
Projects
None yet
Milestone
3.12.1
Development

Successfully merging a pull request may close this issue.

Uploading release APK in Github release instead of standalone APK. kiwix/kiwix-android
2 participants
@kelson42 @MohitMaliFtechiz