Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build osx script #85

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Build osx script #85

wants to merge 5 commits into from

Conversation

drernie
Copy link

@drernie drernie commented Jan 15, 2023

extracted from README and generalized

-b | --build) APP_BUILD="$2"
 -b --build  <build_dir, default:SCRIPT/build>       Folder into which to build the app
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drernie !

I've left some comments, let me know what you think about it 😀

FYI:
Just as a info, as the PR I'm referring to is in WIP status and we still have to take some decisions on that.

A build script for SDL dependencies will likely be exposed soon by Kivy itself, so in order to avoid code duplication we will also need to make the appropriate changes here on kivy-sdk-packager. (Ref: kivy/kivy#8096 )


Requirements::
Platypus needs to be installed. Finally, any python3 version must be available for
initial scripting.
"

echo "-- Set MACOSX_DEPLOYMENT_TARGET"
export SDKROOT=$(xcrun -sdk macosx --show-sdk-path)
export MACOSX_DEPLOYMENT_TARGET=$(xcrun --show-sdk-version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to leave MACOSX_DEPLOYMENT_TARGET set to the minimum supported version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I didn't have that SDK installed, so it wouldn't build unless I changed it.

APP_FRAME="${APP_DIR}/Contents/Frameworks"
SDL_HEAD="${APP_FRAME}/SDL2.framework/Headers"
APP_SDLH="${BUILD_DIR}/SDL/include"
# /Users/quilt/Documents/GitHub/quiltsync/build/SDL/include/SDL.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment left here intentionally?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentional. I actually abandoned this half-way through, but wanted to share my learnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants