Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ios deploy target #949

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Novfensec
Copy link

I just upgraded the latest supported IPHONEOS_DEPLOYMENT_TARGET to 17.0 as XCODE>=13.0 supports 12.0 to 17.5.5 latest.
Please consider this.

@Novfensec Novfensec marked this pull request as ready for review December 6, 2024 08:04
@AndreMiras
Copy link
Member

Hi @Novfensec thank you for looking this up. I'm out of the loop on iOS.
CI seems happy, but did you also test under this configuration yourself and confirm it builds/run OK?
Waiting for you feedback to merge

@Novfensec
Copy link
Author

Novfensec commented Dec 6, 2024

@AndreMiras
Github run:
https://github.com/Novfensec/Tic-Tac-Toe-Android/actions/runs/12195143260

Earlier I got an error for version upgrade.

warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 12.0 to 17.5.99. 

When I upgraded , It passed that step sucessfully and now failing to build Images.xcassets

You can merge this as it resolves the issue with that version incompatibility.

@Novfensec
Copy link
Author

Novfensec commented Dec 7, 2024

Hey! @AndreMiras I got a successfull build at the Github run https://github.com/Novfensec/Tic-Tac-Toe-Android/actions/runs/12210952062 with some little adjustments.

The workflow completed all steps without any failure compiling seamlessly. I'll open up a pull-request for those changes.

@Novfensec Novfensec mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants