Fix height of metadata accordion to accommodate new header #6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build of this pull request fails because of a failing test introduced in #6255 . This also affects the current master. |
|
@solth I will check the selenium test today. |
thomaslow
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Personally, I am not really a fan of dynamic CSS height calculations, but it seems to work. I think it should be possible to use a CSS Flexbox layout instead.
Anyway, I tested your changes. There is no more gap (overflow) in the metadata table.
I also tested your changes in combination with #6285. It works again.
From my point of view, the pull request is ok.
oliver-stoehr
force-pushed
the
fix-metadata-accordion-layout
branch
from
c8653a7
to
13efa88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6291