Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isIriDeleted check does not consider boolean value of the checked triple #3

Open
GGoetzelmann opened this issue Aug 3, 2023 · 2 comments

Comments

@GGoetzelmann
Copy link
Contributor

Check for deleted flag only checks if there is a triple with the "deleted"-predicate, but it does not care if the value of the triple is set to true or false.

result[0] = graph.contains(node, WapVocab.deleted, null);

Might be quite safe at the moment because the value is only set to true, but would not work properly if at some point some 'undelete' operation takes place (via code, via sparql), setting the value to false.

@ThomasJejkal
Copy link
Contributor

...unless the idea was that 'deleted' is only checked to be present and is removed to 'undelete' a certain IRI.

@GGoetzelmann
Copy link
Contributor Author

I think that was the initial idea. Seems a little dangerous and like an idea that might not be shared by all future developers.

Moreover, as stated above, you can 'undelete' the annotation via SPARQL update on the (admin) user side.
Haven't checked it yet, but I, therefore, expect that removing the triple with <http://dem.scc.kit.edu/wapserv/ns#deleted> "true"^^xsd:boolean would undo the deletion, but changing the value to "false"^^xsd:boolean would not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants