Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture: Separate PID record retrieval from PID creation. #60

Open
4 tasks
Pfeil opened this issue Oct 5, 2022 · 0 comments
Open
4 tasks

Architecture: Separate PID record retrieval from PID creation. #60

Pfeil opened this issue Oct 5, 2022 · 0 comments
Labels
enhancement New feature or request maintenance Not a bug, but should be done.
Milestone

Comments

@Pfeil
Copy link
Member

Pfeil commented Oct 5, 2022

For example, in sandboxed mode, it only resolves sandboxed PIDs. This is due to the current architecture: Resolving is part of a PIT-Service-Implementation, so the configured implementation will be used. There are several reasons why this is an issue:

Caused Issues which should be fixed with this approach:

  • Type-Checking uses an extra resolving mechanism, so it can always resolve handle PIDs for that.
  • Only one kind of PID system can be used for resolving PIDs.
  • Only the configured kind of PID can be resolved.
  • Sonarlint scored detected that one implementation has too many responsibilities. We should take it as a sign, considering the previous issues. Split read and write operations into different modules #58

It might be a good idea to not only make a separate module, but make this meta-resolving a separate library for further re-use.

@Pfeil Pfeil added enhancement New feature or request maintenance Not a bug, but should be done. labels Oct 5, 2022
@Pfeil Pfeil added this to the 1.0 milestone Oct 5, 2022
@Pfeil Pfeil removed this from the 1.0 milestone Dec 16, 2022
@Pfeil Pfeil added this to the 2.0.0 milestone May 2, 2023
@Pfeil Pfeil changed the title Sandboxed mode only resolves sandboxed PIDs Separate PID record retrieval from PID creation. May 3, 2023
@Pfeil Pfeil changed the title Separate PID record retrieval from PID creation. Architecture: Separate PID record retrieval from PID creation. May 3, 2023
@Pfeil Pfeil modified the milestones: 2.0.0, 2.1.0 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Not a bug, but should be done.
Projects
None yet
Development

No branches or pull requests

1 participant