-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable using the Type API instead of Cordra to get a profiles JSON Schema. #104
Comments
Hello @Pfeil I would like to work on this. |
Hi, thank you for your interest. I haven't put a lot of effort into this issue so far, but I think before this can be implemented, it needs some refactoring in the validation architecture, as the Type API is involved in validation of PID Records. After some refactoring, this issue can actually be worked on. You may choose to do so, but actually I do not yet have a good/final plan. To see which parts are currently doing validation, you may follow the call of the "create" REST endpoint. You will see that Validation mainly involves the TypeValidationUtils, TypeDefinition, PIDRecord, and the TypeRegistry classes. I think what we require is an interface The new API then would be a new This is probably the issue with most work to do, so far :). Do you have a special interest in the Typed PID Maker or a personal need/priority on this issue? |
Hi @Pfeil. We are currently fully reworking the TypeAPI, so if there are any features you would like to have included there, let us know! |
Hi, thank you for the hint! I guess this is also an indicator to wait with this issue a little until this is done. :) Currently, I do not have additional feature requests or suggestions, but I will keep it in mind. Some minor comments on the current API:
|
Currently, we get the Schemas for the types from Cordra directly. There is a Type API available which we should consider supporting: http://typeapi.pidconsortium.net/docs#/
Introducing a configuration option to choose one of the ways to do it should be considered.
The text was updated successfully, but these errors were encountered: