Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when deleted user name is clicked in Active Members list on dashboard #51

Open
kojiagile opened this issue Sep 23, 2016 · 3 comments

Comments

@kojiagile
Copy link
Contributor

For instance, in Active Members list of All Platforms activity in dashboard, a user kojistudent has been deleted from the CLA toolkit, but it is listed in it. When the name is clicked, an error page is shown.
Not sure users are likely to be deleted in usual operation...
Anyway, either deleted users should not be listed in the list or back-end process should check the existence of users so an error won't occur.

@tommarmstrong
Copy link
Contributor

It looks like a lot of the models refer to users using their username instead of allowing the Django ORM to take care of relations. I think that all code where the username is being used should be refactored to use the ORM as it would automatically take care of this and make for much more maintainable code

@tommarmstrong
Copy link
Contributor

Same cause as #31

@kirstykitto
Copy link
Owner

Yes - agreed Tomasso. Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants