Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could be a great addition to Debug Toolbar #1

Open
MagePsycho opened this issue Apr 3, 2024 · 2 comments
Open

Could be a great addition to Debug Toolbar #1

MagePsycho opened this issue Apr 3, 2024 · 2 comments

Comments

@MagePsycho
Copy link

This can be a great addition to https://github.com/vpietri/magento2-developer-quickdevbar or https://github.com/Smile-SA/magento2-module-debug-toolbar

Any plans for creating a plugin for those toolbars?

@lumnn
Copy link
Contributor

lumnn commented Apr 4, 2024

Thanks for the suggestion. I see that we could potentially add a panels to one of the module, to at least allow easier enabling of the hints and trigger picker with a button.

On the other side I don't want this module to depend on any other toolbars, so integration would have to be optional if both modules are installed.
Majority of the work this module does, is happening on front-end, while the toolbar data and panels are built on backend, so this module would have to inject data into toolbar outside the APIs they provide, making the integration not as bullet proof against any changes made in toolbar modules.

Considering above and limited time I've got to spend on this module I'm probably not going to look into getting this integration sorted anytime soon, but PRs are welcome

@MagePsycho
Copy link
Author

No worries. Thanks for your clarification.
May the other way around is feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants