Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fact typos and formatting #13

Open
tim-west opened this issue Aug 2, 2023 · 2 comments
Open

Fact typos and formatting #13

tim-west opened this issue Aug 2, 2023 · 2 comments
Labels
bug Something isn't working fact A dog fact suggestion

Comments

@tim-west
Copy link

tim-west commented Aug 2, 2023

Thanks for the great api! I noticed some small issues though:

  1. One of the facts is missing the first letter:
    It should be In ancient China, an emperor's instead of n ancient China, an emperor's
  2. There seems to be a mix of straight and curly characters used for apostrophes and speech marks. Ideally curly should be used over straight e.g.
    For apostrophes: ' should be replaced with its curly counterpart
    For speech marks: " " should be replaced with their curly counterparts “ ”
  3. This fact seems to be missing some content:
    Puppies then take a year or more to gain the other half of their body weight.
@tim-west tim-west added the bug Something isn't working label Aug 2, 2023
@kinduff
Copy link
Owner

kinduff commented Aug 3, 2023

Thanks a lot for the report. I updated some of the facts, but I need to review them all to achieve the need of this issue. I will keep this issue up to date and close it when done.

@kinduff kinduff added the fact A dog fact suggestion label Sep 13, 2023
@sunkanmii
Copy link

Hey, @kinduff
I'm a Technical Writer and I love working on OS projects.
It seemed like this needed some help with fixing typos and I was wondering if I could make a PR on this issue so it can be closed.🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fact A dog fact suggestion
Projects
None yet
Development

No branches or pull requests

3 participants