Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ill-formed joins in the spec #124

Open
SimonBin opened this issue May 14, 2024 · 4 comments
Open

Define ill-formed joins in the spec #124

SimonBin opened this issue May 14, 2024 · 4 comments
Assignees
Labels
pending Waiting for another spec or issue to be ready proposal issue has a proposal to be solved RML-core issue related to the core part of the RML vocab RML-join issues relate to joins of RML

Comments

@SimonBin
Copy link

Currently the case for example in https://github.com/kg-construct/rml-core/blob/dd2c79428b5ae1702a3f1f4104b7b7977db32728/test-cases/RMLTC0009a-MySQL/resource.sql

CREATE TABLE student (
  Sport VARCHAR(50),
);
CREATE TABLE sport (
  ID INTEGER,
);
joinCondition: [ rml:parent "ID"; rml:child "Sport" ]

Already fixed in PostgreSQL #115

IMO it should be illegal in RML even if MySQL happens to so accept it

raised by @Aklakan in the chat

@SimonBin
Copy link
Author

nb. the source according to @pmaria https://www.w3.org/2001/sw/rdb2rdf/test-cases/#D009-2tables1primarykey1foreignkey has the correct types

@pmaria pmaria added the test-cases Test cases need to be updated label Jun 25, 2024
@DylanVanAssche
Copy link
Collaborator

Thanks for the issue!

I also agree that ill-formed joins must be rejected. We need to define such 'ill-formed joins' as they can also happen for example in XML or JSON. What happens then if you have a string "5" and integer 5?

RML-Core should define this as joins are part of RML-Core regarding the ReferenceObjectMap and also RML-Logical-View.

CC: @pmaria @andimou @elsdvlee

@DylanVanAssche DylanVanAssche added RML-core issue related to the core part of the RML vocab RML-join issues relate to joins of RML and removed test-cases Test cases need to be updated labels Jul 2, 2024
@dachafra
Copy link
Member

dachafra commented Jul 4, 2024

I think this issue should be fixed in #78, what do you think @elsdvlee @pmaria?

@dachafra dachafra changed the title SQL join on different data types should be ill-defined Define ill-formed joins in the spec Jul 4, 2024
@pmaria
Copy link
Collaborator

pmaria commented Jul 4, 2024

I think this issue should be fixed in #78, what do you think @elsdvlee @pmaria?

@dachafra yes we should be able to incorporate it in that PR eventually. First we need to do some more fundamental (re)writing.

@dachafra dachafra added proposal issue has a proposal to be solved pending Waiting for another spec or issue to be ready labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Waiting for another spec or issue to be ready proposal issue has a proposal to be solved RML-core issue related to the core part of the RML vocab RML-join issues relate to joins of RML
Projects
None yet
Development

No branches or pull requests

6 participants