Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

add initial design overview and threat model #76

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

THS-on
Copy link
Member

@THS-on THS-on commented Mar 10, 2022

This add new section called design. This includes a more high level description of all the components in Keylime and a basic threat model.

@edwards-n
Copy link

I think the threat model and high level design are very helpful documents. A suggestion on UEFI event log versus PCR golden values. Golden values are fragile when you are making changes - we've seen this when attesting physical servers. If you make a change to the system, PCRs can change and there is no easy way to verify that the new value is good. So validation the UEFI event log is more secure. You might want to add something about this to the text.

@THS-on
Copy link
Member Author

THS-on commented Mar 18, 2022

So validation the UEFI event log is more secure. You might want to add something about this to the text.

@edwards-n I hinted to that in the overview, but I agree that it should be more explicit stated in the text.

Copy link

@aplanas aplanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor typos that can be fixed later, but this test is really useful.

@THS-on
Copy link
Member Author

THS-on commented Mar 25, 2022

@edwards-n I added now a statement that the measured boot policy engine is preferred over static PCR values.

@aplanas If you have the time can you mark the typos? Then I can fix them in this PR.

@kkaarreell I added the inclusion of a nonce in the quote. Is this explanation enough?

@aplanas
Copy link

aplanas commented Mar 25, 2022

If you have the time can you mark the typos?

Sure, I am not English native and is usually others pointing me

docs/design/overview.rst Outdated Show resolved Hide resolved
docs/design/overview.rst Outdated Show resolved Hide resolved
docs/design/overview.rst Outdated Show resolved Hide resolved
docs/design/overview.rst Outdated Show resolved Hide resolved
docs/design/overview.rst Outdated Show resolved Hide resolved
docs/design/overview.rst Outdated Show resolved Hide resolved
docs/design/threat_model.rst Show resolved Hide resolved
docs/design/threat_model.rst Outdated Show resolved Hide resolved
docs/design/threat_model.rst Outdated Show resolved Hide resolved
docs/design/threat_model.rst Outdated Show resolved Hide resolved
@kkaarreell
Copy link

@kkaarreell I added the inclusion of a nonce in the quote. Is this explanation enough?

@THS-on yes, thank you.

@mpeters
Copy link
Member

mpeters commented Mar 29, 2022

@THS-on did you want to fix those typos in this PR or the next?

@THS-on
Copy link
Member Author

THS-on commented Mar 29, 2022

@THS-on did you want to fix those typos in this PR or the next?

@mpeters I'll fix them tomorrow in this PR.

@THS-on
Copy link
Member Author

THS-on commented Mar 30, 2022

@aplanas thanks for the comments! I updated the document to include fixes for them.

@mpeters mpeters merged commit caf8bae into keylime:master Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants