Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure keycloak-quickstarts main branch to have released versions of server and client #35433

Open
1 of 6 tasks
Tracked by #30787
mposolda opened this issue Nov 28, 2024 · 0 comments
Open
1 of 6 tasks
Tracked by #30787

Comments

@mposolda
Copy link
Contributor

mposolda commented Nov 28, 2024

We had the discussion about quickstarts within the wider team. The approach, which we are going to use is the following:

  • In quickstarts, we won't have anymore branch latest. We will have just the branch main. This will be also the default branch

  • The main branch of quickstarts won't have references to snapshot versions of keycloak and keycloak-client. Instead, it will have references to last released version of keycloak server and last released version of keycloak-client. In other words, those lines will be always set to last released version of keycloak server and keycloak-client (Keycloak-client was already updated yesterday by Stian to last released version 26.0.2): https://github.com/keycloak/keycloak-quickstarts/blob/main/pom.xml#L38-L39

  • During the release of keycloak server, it will update just this one line in main branch in pom.xml with the server version. Similarly for the release of keycloak-client.

  • There won't be tags for community quickstarts (looks that nobody using them anyway)

  • Sending PRs: The proposal above means that if people are sending PRs to quickstarts, they will need to do quickstart examples which work with the last released version of server and client. So for example if you want to add quickstart for some new feature, which is going to be developed in 26.1.0, it means that this quickstart can be merged to main branch after the Keycloak server 26.1.0 is released. It cannot be merged before though due the server version in pom.xml is pointing to last released version (which is not 26.1.0, but some older like 26.0.X).

Tasks

  1. team/core-clients
    mposolda
  2. kind/task team/core-clients
  3. status/hold team/core-clients
  4. status/hold team/core-clients
  5. team/core-clients
  6. rmartinc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant