Add Secret Question authenticator back #633
Open
+943
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stianst <[email protected]> Add Secret Question authenticator back To do that, implemented `getCredentialType` for `SecretQuestionRequiredAction` Closes keycloak#553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #553
Attempts to add back the "Authenticator SPI walk through" example that is missing. Right now the reference the docs point to does not exist: https://www.keycloak.org/docs/26.0.6/server_development/#_auth_spi_walkthrough
I just cherrypicked stianst's commit that is missing from the
mainbranch and added the implementation ofSecretQuestionRequiredAction.getCredentialType, as per mposolda's comment: #553 (comment)Tested it locally with keycloak 26.0.6 and it works fine.
Please let me know if I messed anything up with the squash in terms of history/blame.