Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where is the old authenticator example? #553

Open
oculos opened this issue Apr 19, 2024 · 2 comments · May be fixed by #633
Open

Where is the old authenticator example? #553

oculos opened this issue Apr 19, 2024 · 2 comments · May be fixed by #633
Assignees
@mposolda
Labels
help wanted impact/medium kind/bug
Milestone
25.0.0

Comments

@oculos
Copy link

oculos commented Apr 19, 2024

Describe the bug

According to this, the example should be under extensions:
keycloak/keycloak@1f772d2

I recall seeing it there, but I can't find it anymore. Is it deprecated now?

Version

24.0.3

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Anything else?

No response
@mposolda mposolda added this to the 25.0.0 milestone May 2, 2024
@mposolda
Copy link
Contributor

mposolda commented May 2, 2024 •
edited
Loading

@oculos Update: The PR to quickstarts was here #540 , however it was sent to keycloak:latest and hence it was automatically removed during the release of Keycloak 24.0.3 as correct branch for pull requests is keycloak:main .

PR is welcome to the main branch if you have a time :-) It should work with the same content as was in the #540 , but may require adding method getCredentialType() (See keycloak/keycloak@c427e653 for the details).

@mposolda mposolda self-assigned this May 2, 2024
@cornelpurcel
Copy link

Hi @mposolda , can I try to take care of the PR to introduce the Authenticator example back?

cornelpurcel added a commit to cornelpurcel/keycloak-quickstarts that referenced this issue Dec 1, 2024
@cornelpurcel
Add Secret Question authenticator back
2267ee2 
To do that, implemented `getCredentialType` for `SecretQuestionRequiredAction`

Closes keycloak#553
cornelpurcel pushed a commit to cornelpurcel/keycloak-quickstarts that referenced this issue Dec 1, 2024
@stianst @cornelpurcel
Move authenticator example to quickstarts
a123bb1 
Signed-off-by: stianst <[email protected]>

Add Secret Question authenticator back

To do that, implemented `getCredentialType` for `SecretQuestionRequiredAction`

Closes keycloak#553
@cornelpurcel cornelpurcel linked a pull request Dec 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mposolda mposolda

Labels
help wanted impact/medium kind/bug
Projects
None yet
Milestone
25.0.0
Development

Successfully merging a pull request may close this issue.

Add Secret Question authenticator back cornelpurcel/keycloak-quickstarts
3 participants
@mposolda @cornelpurcel @oculos