Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelphesRootReader_ee_91gev test failing #129

Closed
andresailer opened this issue Oct 2, 2024 · 7 comments · Fixed by #130
Closed

DelphesRootReader_ee_91gev test failing #129

andresailer opened this issue Oct 2, 2024 · 7 comments · Fixed by #130

Comments

@andresailer
Copy link

2/7 Test #5: DelphesRootReader_ee_91gev .....................***Failed 8.78 sec

See log files.

@tmadlener
Copy link
Contributor

The test seems to be pretty flaky. I get a roughly 30% failure rate locally. The main issue is that it's not entirely easy to reproduce, because even with a fixed random seed for delphes I sometimes get it to pass sometimes and to fail the other times.

@andresailer
Copy link
Author

We can add a --repeat until-pass:5 to ctest then

@tmadlener
Copy link
Contributor

I didn't even know that is a thing... Let me check quickly whether I find an obvious issue with the seeding just to rule out any stupid issues.

@andresailer
Copy link
Author

andresailer commented Oct 2, 2024

Although of course it depends on why that test actually fails? Just flaky comparison, or something else.

@tmadlener
Copy link
Contributor

OK. RandomSeed setting doesn't seem to be the problem. The issue with --repeat until-pass:N is that the key4hep CI workflow doesn't expose that possibility to us.

@andresailer
Copy link
Author

That missing ctest hook is probably something @jmcarcell can fix.

@tmadlener
Copy link
Contributor

tmadlener commented Oct 2, 2024

It seems to be very consistent in CI, even --repeat until-pass:5 doesn't do much there: https://github.com/key4hep/k4SimDelphes/actions/runs/11147612771/job/30982426010?pr=130

c.f. #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants