Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelphesROOT_EDM4HEP failes #123

Closed
chekanov opened this issue Jul 15, 2024 · 7 comments · Fixed by #125
Closed

DelphesROOT_EDM4HEP failes #123

chekanov opened this issue Jul 15, 2024 · 7 comments · Fixed by #125

Comments

@chekanov
Copy link

Hello,

I was testing DelphesROOT_EDM4HEP, but it looks like I cannot read truth level information created by Delphes 3.5 using this binary file. I use:

/cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh

on el9. First I was using Delphes 3.5 with the supplied cards/gen_card.tcl which fills truth-level "particle" record.

This gives me "truth.root"

Then I checked

DelphesROOT delphes_card_IDEA.tcl test_RECO.root truth.root

It works fine. Then I ran:

DelphesROOT_EDM4HEP card_IDEA.tcl edm4hep.tcl test_EDM.root truth.root

It suck on 1st events (without error)

best, Sergei

@tmadlener
Copy link
Contributor

Hi Sergei,

Thanks for the report. Could you provide us the truth.root and edm4hep.tcl files for debugging? Since it is working with Delphes, I am suspecting either a bug in our reader, or an issue in the configuration.

@chekanov
Copy link
Author

Hi, Thomas

Please try this file: https://mc.hep.anl.gov/asc/hepsim/tmp/gev91ee_zboson_001.root

It was made with Delphes 3.5 using the card cards/gen_card.tcl. It works with the original Delphes, but fails with DelphesROOT_EDM4HEP

best

@chekanov
Copy link
Author

Sorry, I've forgotten. My edm4hep.tcl for this example looks like this:


 module EDM4HepOutput EDM4HepOutput {
    add ReconstructedParticleCollections EFlowTrack EFlowPhoton EFlowNeutralHadron
    add GenParticleCollections           Particle
    add JetCollections                   Jet
    add MuonCollections                  Muon
    add ElectronCollections              Electron
    add PhotonCollections                Photon
    set RecoParticleCollectionName       ReconstructedParticles
    set MCRecoAssociationCollectionName  MCRecoAssociations
}

@tmadlener
Copy link
Contributor

I couldn't exactly reproduce a hanging behavior, but we definitely had a bug in the DelphesROOT_EDM4HEP executable, such that it never entered the event loop. I have opened #125 with a simple fix. Can you check whether that fixes things for you?

@chekanov
Copy link
Author

Hi, Thomas

Thanks, exactly, it never starts the loop over events. Should I just use

source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh

for checking?

best, Sergei

@tmadlener
Copy link
Contributor

Hi Sergei, the changes should be available from the nightlies tomorrow. (The setup script you use is the correct one)

@tmadlener tmadlener reopened this Jul 29, 2024
@chekanov
Copy link
Author

Hi, Thomas

Thanks. It looks like it works now. At least it loops over events. I'll check the outputs.

best, Sergei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants