Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of VTX digitisation for IDEA vertex detector #11

Merged
merged 9 commits into from
Dec 19, 2023
Merged

First version of VTX digitisation for IDEA vertex detector #11

merged 9 commits into from
Dec 19, 2023

Conversation

armin-ilg
Copy link
Collaborator

@armin-ilg armin-ilg commented Sep 26, 2023

Hi @BrieucF

Here is a first version of the digitisaton for the vertex detector/silicon detectors.
For the moment, it only applies a Gaussian smearing to the hits. I will refine this more over time.

One issue I still have is that I cannot do the digitisation of the various vertex subdetectors simultaneously, when uncommenting all VTXdigitizers (here).

I will also make sure that it works properly with the CLD vertex detector.

@BrieucF
Copy link
Collaborator

BrieucF commented Sep 26, 2023

One issue I still have is that I cannot do the digitisation of the various vertex subdetectors simultaneously, when uncommenting all VTXdigitizers (here).

Each digitizer should have a different name: https://github.com/armin-ilg/k4RecTracker/blob/aa306b2786a4a031876c18f860c15df2e15209b2/VTXdigi/test/runVTXdigitizer.py#L170C32-L170C44 ?

@armin-ilg
Copy link
Collaborator Author

Hi @BrieucF

It should be okay now, forcing the hits onto the surfaces works. k4RecTracker can be used to digitise the IDEA vertex or Silicon Wrapper or any of the CLD tracking layers.
Shall we merge it? Do you know what is wrong with all the tests? Running
k4run test/runVTXdigitizer.py
works for me locally

@BrieucF
Copy link
Collaborator

BrieucF commented Dec 19, 2023

Hi Armin, thanks! Merging this for now, we can do the modifications in a second PR:

  • migrate configuration files to ddsim workflow (using the ddsim output and removing the k4SimGeant4 related steps)
  • use a thread safe random number generator (align with k4Reco)
  • have association between tracker hits and sim tracker hits out of the digitizer: https://github.com/key4hep/EDM4hep/blob/main/edm4hep.yaml#L457

@BrieucF BrieucF merged commit 02cf300 into key4hep:master Dec 19, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants