-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple minor fixes #207
Multiple minor fixes #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more destructors that could be cleaned-up (or removed according to rule of 0):
~LcioEvent
~LCEventWrapper
~LcioEventOutput
~MarlinProcessorWrapper
~TrackingCellIDEncodingSvc
bb6d7bb
to
4eb1ea5
Compare
- Don't use the deprecated service retrieval - Add override when possible and use the default destructors instead of implementing them
1855128
to
8c1ae10
Compare
For my own elucidation: why not |
By convention, we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not really consistent with override
and final
here. Sometimes we use both, sometimes only one. I have a few examples below.
BEGINRELEASENOTES
final
when possible and use the default destructors instead of implementing them!
instead ofnot
inif(...)
!
instead of comparing tonullptr
ENDRELEASENOTES