Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple minor fixes #207

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Multiple minor fixes #207

merged 8 commits into from
Dec 10, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Dec 9, 2024

BEGINRELEASENOTES

  • Don't use the deprecated service retrieval
  • Add final when possible and use the default destructors instead of implementing them
  • Use ! instead of not in if(...)
  • Use ! instead of comparing to nullptr
  • Simplify setting the environment for tests, avoiding having to duplicate the names
  • Clean up some includes in header and source files

ENDRELEASENOTES

Copy link
Contributor

@m-fila m-fila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more destructors that could be cleaned-up (or removed according to rule of 0):

  • ~LcioEvent
  • ~LCEventWrapper
  • ~LcioEventOutput
  • ~MarlinProcessorWrapper
  • ~TrackingCellIDEncodingSvc

k4MarlinWrapper/k4MarlinWrapper/converters/EDM4hep2Lcio.h Outdated Show resolved Hide resolved
@andresailer
Copy link
Collaborator

For my own elucidation: why not not?

@jmcarcell
Copy link
Member Author

By convention, we use ! almost everywhere.

Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not really consistent with override and final here. Sometimes we use both, sometimes only one. I have a few examples below.

k4MarlinWrapper/k4MarlinWrapper/LcioEventAlgo.h Outdated Show resolved Hide resolved
k4MarlinWrapper/k4MarlinWrapper/converters/EDM4hep2Lcio.h Outdated Show resolved Hide resolved
@tmadlener tmadlener merged commit 47368c8 into main Dec 10, 2024
11 checks passed
@tmadlener tmadlener deleted the minor-fixes branch December 10, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants