Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results of clic reconstruction changed for nightlies #170

Closed
tmadlener opened this issue Feb 7, 2024 · 1 comment · Fixed by key4hep/EDM4hep#266
Closed

Results of clic reconstruction changed for nightlies #170

tmadlener opened this issue Feb 7, 2024 · 1 comment · Fixed by key4hep/EDM4hep#266

Comments

@tmadlener
Copy link
Contributor

The CI is failing on alma9 and ubuntu22 (and I can reproduce this locally) because for the nightlies the number of MCParticlesSkimmed has changed wrt to the expected outcome. Things are still working on the release. I am not sure if the issue is actually in the wrapper or rather in some of the wrapped processors (or some other machinery). I am opening the issue here, because this is where things become visible at the moment.
@tmadlener
Copy link
Contributor Author

tmadlener commented Feb 7, 2024 •
edited
Loading

Changes happened between 2024-01-23 and 2024-01-24 for the nightlies on alma9.

edit: That almost certainly makes it this PR: key4hep/EDM4hep#237

@tmadlener tmadlener mentioned this issue Feb 7, 2024
Merged
@tmadlener tmadlener mentioned this issue Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Make MCParticle momenta use doubles instead of floats" key4hep/EDM4hep
1 participant
@tmadlener