From d332387e71a268e20492f506bf5cd12431e3991d Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Thu, 19 Dec 2024 17:19:01 +0100 Subject: [PATCH] Remove the unnecessary universal reference The frame is move only in any case --- k4FWCore/components/MetadataSvc.cpp | 2 +- k4FWCore/components/MetadataSvc.h | 2 +- k4FWCore/include/k4FWCore/IMetadataSvc.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/k4FWCore/components/MetadataSvc.cpp b/k4FWCore/components/MetadataSvc.cpp index d87f0845..4edcb5e5 100644 --- a/k4FWCore/components/MetadataSvc.cpp +++ b/k4FWCore/components/MetadataSvc.cpp @@ -45,6 +45,6 @@ StatusCode MetadataSvc::finalize() { return Service::finalize(); } const podio::Frame* MetadataSvc::getFrame() const { return m_frame.get(); } podio::Frame* MetadataSvc::getFrame() { return m_frame.get(); } -void MetadataSvc::setFrame(podio::Frame&& frame) { m_frame = std::make_unique(std::move(frame)); } +void MetadataSvc::setFrame(podio::Frame frame) { m_frame = std::make_unique(std::move(frame)); } DECLARE_COMPONENT(MetadataSvc) diff --git a/k4FWCore/components/MetadataSvc.h b/k4FWCore/components/MetadataSvc.h index 13a8703f..c47887e8 100644 --- a/k4FWCore/components/MetadataSvc.h +++ b/k4FWCore/components/MetadataSvc.h @@ -42,7 +42,7 @@ class MetadataSvc : public extends { const podio::Frame* getFrame() const override; podio::Frame* getFrame() override; - void setFrame(podio::Frame&& frame) override; + void setFrame(podio::Frame frame) override; }; #endif diff --git a/k4FWCore/include/k4FWCore/IMetadataSvc.h b/k4FWCore/include/k4FWCore/IMetadataSvc.h index 6066a301..65748d6e 100644 --- a/k4FWCore/include/k4FWCore/IMetadataSvc.h +++ b/k4FWCore/include/k4FWCore/IMetadataSvc.h @@ -29,7 +29,7 @@ class IMetadataSvc : virtual public IInterface { public: DeclareInterfaceID(IMetadataSvc, 1, 0); - virtual void setFrame(podio::Frame&& frame) = 0; + virtual void setFrame(podio::Frame frame) = 0; template void put(const std::string& name, const T& obj) { if (!getFrame()) {