Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion of track holes #85

Closed
tmadlener opened this issue Jul 30, 2024 · 0 comments · Fixed by #95
Closed

Add conversion of track holes #85

tmadlener opened this issue Jul 30, 2024 · 0 comments · Fixed by #95
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tmadlener
Copy link
Contributor

Introduced in key4hep/EDM4hep#337 and iLCSoft/LCIO#147

Should be fairly straight forward to fix. The main changes are

  • Bump the minimum version requirements for EDM4hep and LCIO in the find_package calls
  • Add the conversion of the two new fields in the convertTracks functions in a similar way as the number of subdetector hits.

EDM4hep -> LCIO

k4EDM4hep2LcioConv/k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4EDM4hep2LcioConv.ipp

Line 18 in 7ef18e3

std::unique_ptr<lcio::LCCollectionVec> convertTracks(const edm4hep::TrackCollection* const edmCollection,

LCIO -> EMD4hep

k4EDM4hep2LcioConv/k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.ipp

Line 356 in 7ef18e3

std::vector<CollNamePair> convertTracks(const std::string& name, EVENT::LCCollection* LCCollection,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert Nholes and subdetectorHoleNumbers for tracks key4hep/k4EDM4hep2LcioConv
1 participant
@tmadlener