Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear what edm4hep::ReconstructedParticle::type should be #183

Closed
DraTeots opened this issue Oct 27, 2022 · 2 comments
Closed

Unclear what edm4hep::ReconstructedParticle::type should be #183

DraTeots opened this issue Oct 27, 2022 · 2 comments

Comments

@DraTeots
Copy link

On schema yaml file it is said

edm4hep::ReconstructedParticle:
    Description: "Reconstructed Particle"
    Author : "F.Gaede, DESY"
    Members:
      - int32_t type //type of reconstructed particle. Check/set collection parameters ReconstructedParticleTypeNames and ReconstructedParticleTypeValues.

But there is no definition of ReconstructedParticleTypeNames nor ReconstructedParticleTypeValues. Unable to find any indication of how this type field should be set and what is the convention

@tmadlener
Copy link
Contributor

For all intents and purposes this can probably be treated as PDG, and there are plans to rename this to something that indicates this. There is a brief discussion about this in #146 as well

@jmcarcell
Copy link
Member

type has been renamed in #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants