Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with tracker hit associations (VXDTrackerHitRelations)? #48

Closed
doloresgarcia opened this issue Jul 23, 2024 · 4 comments · Fixed by key4hep/k4EDM4hep2LcioConv#88

Comments

@doloresgarcia
Copy link

using the nightlies, the last CLDConfig and CLD_o2_v06, VXDTrackerHitRelations (as well as other relation collections for the tracker hits) rec and sim index are filled with -2s

an example file can be found here:
/eos/experiment/fcc/ee/datasets/CLD_tracking/condor/Pythia_eval/Zcard_CLD_v3/1/out_reco_edm4hep_edm4hep.root

@Zehvogel
Copy link
Collaborator

I would suspect this check

https://github.com/key4hep/k4EDM4hep2LcioConv/blob/73793abf6794c48e27c0a584e645d2f0a0377f48/k4EDM4hep2LcioConv/include/k4EDM4hep2LcioConv/k4Lcio2EDM4hepConv.ipp#L856

Still need to figure out why it fails though, maybe something in the translation mappings has changed unexpectedly recently @tmadlener?

@tmadlener
Copy link
Contributor

When did it start failing? My suspicion would be that it's an issue related to TrackerHitPlane vs TrackerHit in the filling of the association. We have removed the association from TrackerHitPlane to SimTrackerHit in EDM4hep (key4hep/EDM4hep#331). The corresponding changes in the converter are: key4hep/k4EDM4hep2LcioConv#73 and key4hep/k4EDM4hep2LcioConv#76

@Zehvogel
Copy link
Collaborator

I think I found one suspicious bit but I don't think that it was the source of this error key4hep/k4EDM4hep2LcioConv#83

As there are still associations created but just default initialised (which I would think from the -2) this check should not have been the problem.

Does it maybe just not work because the typeMapping.trackerHits that is also passed for TrackerHitPlanes contains a mapping to TrackerHit3D and not to the TrackerHit interface? I think that would fit with the above error :)

@andresailer
Copy link
Collaborator

Does it maybe just not work because the typeMapping.trackerHits that is also passed for TrackerHitPlanes contains a mapping to TrackerHit3D and not to the TrackerHit interface? I think that would fit with the above error :)

indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants