Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: non-Eureka! inputs in Stage 4 meta (data_format) is overwritten in new Eureka! version #734

Open
2 tasks done
evamariaa opened this issue Jan 9, 2025 · 0 comments
Assignees
Labels
bug Something isn't working LC Fit

Comments

@evamariaa
Copy link
Collaborator

FAQ check

  • Yes, I checked the FAQ and my question has not been addressed.

Instrument

Light curve fitting (Stages 4-6)

What happened?

Following the jupyter notebook tutorial on preparing the non-Eureka! input data for starting with Stage 4, the data_format is set to 'custom' in there. But it is later essentially overwritten when calling Stage 4 as meta = S4MetaClass(..) initialises as data_format = 'eureka' via super through MetaClass. All this is then done before it assigns non-default values as intended which then crash Stage 4.

My suggestion is that either the data_format is defined as custom in the S4 ECF file when calling non-Eureka! inputs or we change it in mergeevents such that the data_format can be overwritten with the S3 input data?

Credit to my student @StaudtPatrick for finding this bug.

Error traceback output

No response

What operating system are you using?

Linux

What version of Python are you running?

Python 3.10.14

What Python packages do you have installed?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@evamariaa evamariaa added the bug Something isn't working label Jan 9, 2025
@github-actions github-actions bot added the LC Fit label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working LC Fit
Projects
None yet
Development

No branches or pull requests

3 participants