Make namespace and flow optional when using keep_original_source = true

[tchiotludo]

right now, we could read it from the yaml like that

resource "kestra_flow" "demo_flows" {
  for_each = fileset(path.module, "kestra/io.kestra.demo/*.yml")
  flow_id = yamldecode(templatefile(each.value, {}))["id"]
  namespace = yamldecode(templatefile(each.value, {}))["namespace"]
  content = templatefile(each.value, {})
  keep_original_source = true
}

but we are able to read it directly from the yaml since the id and namespace are mandatory

[aballiet]

Or make the opposite : use terraform fields and internally generate this mandatory part of the YAML.
Makes sense to define these values with TF params to me.

WDYT ?

[tchiotludo]

I've an issue, the goal keep_original_source is to kept exact source of the flow, if the people want to add comment everywhere (at the beginning, end, between namespace and id properties), it must be able to it, when we unserialize, serialize a yaml string, most of parsers will break that (remove comment, changing quote, ...), so it appear to be not the good way

[aballiet]

Okey, and what about doing it in the API call : https://kestra.io/docs/api-guide/#post-/api/v1/flows.

Using values from content for everything except id and namespace if var provided using TF ressource, otherwise use all values from content.

terraform-provider-kestra/internal/provider/resource_flow.go

Lines 63 to 92 in e0fff3d

	if yamlSourceCode == true {
	r, reqErr := c.yamlRequest("POST", "/api/v1/flows", stringToPointer(d.Get("content").(string)))
	if reqErr != nil {
	return diag.FromErr(reqErr.Err)
	}
	errs := flowSourceApiToSchema(r.(map[string]interface{}), d)
	if errs != nil {
	return errs
	}
	return diags
	} else {
	body, err := flowSchemaToApi(d)
	if err != nil {
	return diag.FromErr(err)
	}
	r, reqErr := c.request("POST", "/api/v1/flows", body)
	if reqErr != nil {
	return diag.FromErr(reqErr.Err)
	}
	errs := flowApiToSchema(r.(map[string]interface{}), d)
	if errs != nil {
	return errs
	}
	return diags
	}

tldr : not having to unserialize, serialize a yaml string

[aballiet]

In the end it's more a question about how we see the terraform provider.

If no logic at all should be implemented within the provider then we go with only content & keep_original_source params.

Otherwise we could also have flow_id, namespace and some other future fields.

[Skraye]

As discuss with Ludo long times ago, this would be tricky, so we decided that the change will be done when we will fully change the API to create flows

[aballiet]

As discuss with Ludo long times ago, this would be tricky, so we decided that the change will be done when we will fully change the API to create flows

OK yes. Can't wait for this. Do you have an idea when it will be released?

[Skraye]

@aballiet We just deprecated methods using JSON to create/edit flow, so I can't really tell