From c0966c779ccde6b7ddffececf7995a1ff4fb61cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Mathieu?= <loikeseke@gmail.com>
Date: Fri, 13 Sep 2024 10:56:41 +0200
Subject: [PATCH] feat: support ssh/rsa

---
 .../java/io/kestra/plugin/fs/ssh/Command.java | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/src/main/java/io/kestra/plugin/fs/ssh/Command.java b/src/main/java/io/kestra/plugin/fs/ssh/Command.java
index d52678f..92567cc 100644
--- a/src/main/java/io/kestra/plugin/fs/ssh/Command.java
+++ b/src/main/java/io/kestra/plugin/fs/ssh/Command.java
@@ -104,7 +104,7 @@ public class Command extends Task implements SshInterface, RunnableTask<Command.
         additionalProperties = String.class,
         dynamic = true
     )
-    protected Map<String, String> env;
+    private Map<String, String> env;
 
     @Builder.Default
     @Schema(
@@ -112,7 +112,15 @@ public class Command extends Task implements SshInterface, RunnableTask<Command.
     )
     @PluginProperty
     @NotNull
-    protected Boolean warningOnStdErr = true;
+    private Boolean warningOnStdErr = true;
+
+    @Builder.Default
+    @Schema(
+        title = "Enable the disabled by default RSA/SHA1 algorithm"
+    )
+    @PluginProperty
+    @NotNull
+    private Boolean enableSshRsa1 = false;
 
     @Override
     public Command.ScriptOutput run(RunContext runContext) throws Exception {
@@ -149,6 +157,13 @@ else if (authMethod == AuthMethod.PUBLIC_KEY) {
             jsch = new JSch();
             session = jsch.getSession(runContext.render(username), renderedHost, Integer.parseInt(renderedPort));
 
+            // enable disabled by default weak RSA/SHA1 algorithm
+            if (Boolean.TRUE.equals(enableSshRsa1)) {
+                runContext.logger().info("RSA/SHA1 is enabled, be advise that SHA1 is no longer considered secure by the general cryptographic community.");
+                session.setConfig("server_host_key", session.getConfig("server_host_key") + ",ssh-rsa");
+                session.setConfig("PubkeyAcceptedAlgorithms", session.getConfig("PubkeyAcceptedAlgorithms") + ",ssh-rsa");
+            }
+
             if (authMethod == AuthMethod.PASSWORD) {
                 session.setConfig("PreferredAuthentications", "password");
                 session.setPassword(runContext.render(password));